Skip to content

Remove instances of allow(improper_ctypes) #1006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Aug 7, 2025

i128/u128 haven't flagged improper_ctypes for a while, and this just
made it to stable 1. Remove the allows as they are no longer needed.

@niacdoial
Copy link

huh!
I was trying to do part of what this PR does, and I only saw you were already doing it because I was looking into how to make local tests work
anywho, thanks!

i128/u128 haven't flagged `improper_ctypes` for a while, and this just
made it to stable [1]. Remove the `allow`s as they are no longer needed.

[1]: https://blog.rust-lang.org/2025/08/07/Rust-1.89.0/#i128-and-u128-in-extern-c-functions
@tgross35 tgross35 force-pushed the no-improper-ctypes branch from ab561f8 to 6c8bf5a Compare August 7, 2025 17:33
@tgross35 tgross35 marked this pull request as ready for review August 7, 2025 17:33
@tgross35 tgross35 merged commit 6c8bf5a into rust-lang:master Aug 7, 2025
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants