Make url optional via a new "cred" feature gate for credential helpers; disable default features #1168
Conversation
Add an enabled-by-default feature flag for credential helpers, which are the only uses of the `url` crate. This reduces a `default-features = false` build of git2 from 54 dependencies to 17, for a configuration that many tools (e.g. anything that only cares about local repositories) can happily use. In addition to enabling it by default, make the "https" and "ssh" features depend on "cred".
joshtriplett
force-pushed
the
cred-feature
branch
from
4cc6bed to
da9c98d
Compare
…inary size With current git2, this reduces lstr from 144 dependencies to 137, and from 4.3M to 3.6M. With rust-lang/git2-rs#1168 merged into upstream git2-rs, it further reduces lstr to 107 dependencies (though with negligible additional improvement to binary size as the additional dependencies were compiled out).
…inary size With current git2, this reduces lstr from 144 dependencies to 137, and from 4.3M to 3.6M. With rust-lang/git2-rs#1168 merged into upstream git2-rs, it further reduces lstr to 106 dependencies (though with negligible additional improvement to binary size as the additional dependencies were compiled out).
|
Wow, I did not know that's how url works. This will need to be a major change, correct? |
|
@ehuss The new That said, a major version bump would still be the safest approach. And, if we bump the major version, I think we should consider disabling some or all of these features by default. |
Many users of the git2 crate want to operate exclusively on local repositories, but if they don't use `default-features = false` they'll get a large set of additional dependencies they don't need.
joshtriplett
changed the title
|
Rather than hoping the change will have no impact on users of 0.20, I've bumped the version to 0.21, and then disabled default features (since we can do that over a semver-major release). |
joshtriplett
force-pushed
the
cred-feature
branch
from
da37c28 to
0b5342a
Compare
joshtriplett
force-pushed
the
cred-feature
branch
from
0b5342a to
875a4cc
Compare
|
@joshtriplett I'm having some second thoughts about removing the default features. For example, this essentially breaks some of the examples that are in this repository. I don't really have any data to say whether the majority of users of this library need networking or not. Generally I believe that the difficulty of carefully including the correct set of features ( |
Add a new feature flag for credential helpers, which are the only uses of the
urlcrate. This reduces a build of git2 from 54 dependencies to 17, for a configuration that many tools (e.g. anything that only cares about local repositories) can happily use.Make the "https" and "ssh" features depend on "cred".
Disable all of these features by default, to avoid extra dependencies in the common case of tools that only care about local repositories.
Bump the crate version to 0.21.