Skip to content

Define ip_mreqn on all Linux platforms #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Define ip_mreqn on all Linux platforms #2642

merged 1 commit into from
Jan 24, 2022

Conversation

tamird
Copy link
Contributor

@tamird tamird commented Jan 22, 2022

Updates #1558.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

@tamird tamird marked this pull request as ready for review January 22, 2022 13:18
@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 22, 2022

📌 Commit e1eeade has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jan 22, 2022

⌛ Testing commit e1eeade with merge b7af874...

bors added a commit that referenced this pull request Jan 22, 2022
Define ip_mreqn on all Linux platforms

Closes #1558.
@bors
Copy link
Contributor

bors commented Jan 22, 2022

💔 Test failed - checks-actions

@tamird
Copy link
Contributor Author

tamird commented Jan 22, 2022

Where can I see the failure details?

@Amanieu
Copy link
Member

Amanieu commented Jan 22, 2022

The failure details are here: https://github.com/rust-lang/libc/runs/4908786386?check_suite_focus=true

It seems like passing ip_mreqn by value is somehow corrupting the value on sparc64.

@JohnTitor Do you have any idea what could be causing this? I'm stumped.

@tamird
Copy link
Contributor Author

tamird commented Jan 23, 2022

@Amanieu I've suppressed this test on sparc64 for now; can I get another try run?

@Amanieu
Copy link
Member

Amanieu commented Jan 24, 2022

@bors r+

@bors
Copy link
Contributor

bors commented Jan 24, 2022

📌 Commit da84eef has been approved by Amanieu

@bors
Copy link
Contributor

bors commented Jan 24, 2022

⌛ Testing commit da84eef with merge eadfdf5...

bors added a commit that referenced this pull request Jan 24, 2022
Define ip_mreqn on all Linux platforms

Updates #1558.
@bors
Copy link
Contributor

bors commented Jan 24, 2022

💔 Test failed - checks-actions

@tamird
Copy link
Contributor Author

tamird commented Jan 24, 2022

This failure looks unrelated (and strange):

    Finished test [unoptimized + debuginfo] target(s) in 1m 47s
     Running test/cmsg.rs (target/arm-unknown-linux-musleabihf/debug/deps/cmsg-0f644353fa7d873a)

running 5 tests
test t::test_cmsg_data ... ok
error: test failed, to rerun pass '--test cmsg'

Caused by:
  process didn't exit successfully: `qemu-arm -L /musl-arm /checkout/target/arm-unknown-linux-musleabihf/debug/deps/cmsg-0f644353fa7d873a` (signal: 11, SIGSEGV: invalid memory reference)
Error: Process completed with exit code 101.

https://github.com/rust-lang/libc/runs/4915659168?check_suite_focus=true

Can we retry?

@Amanieu
Copy link
Member

Amanieu commented Jan 24, 2022

@bors retry

@bors
Copy link
Contributor

bors commented Jan 24, 2022

⌛ Testing commit da84eef with merge 4d03473...

@bors
Copy link
Contributor

bors commented Jan 24, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: Amanieu
Pushing 4d03473 to master...

@bors bors merged commit 4d03473 into rust-lang:master Jan 24, 2022
@tamird tamird deleted the mreqn-all-linux branch January 24, 2022 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants