Skip to content

Trigger parameter info automatically #3498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 6, 2020
Merged

Trigger parameter info automatically #3498

merged 3 commits into from
Mar 6, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Mar 6, 2020

See microsoft/vscode#64023

bors r+
🤖

@matklad
Copy link
Member Author

matklad commented Mar 6, 2020

cc @iTZAvishay, lest you hit another merge conflict :)

@bors
Copy link
Contributor

bors bot commented Mar 6, 2020

@bors bors bot merged commit 8e8c5a7 into rust-lang:master Mar 6, 2020
Copy link
Contributor

@Avishayy Avishayy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotta love sippets ;)

@@ -54,6 +54,7 @@ impl Default for FeatureFlags {
FeatureFlags::new(&[
("lsp.diagnostics", true),
("completion.insertion.add-call-parenthesis", true),
("completion.insertion.add-argument-sippets", true),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sippets

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed in #3500

@matklad matklad deleted the snip branch March 6, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants