Skip to content

Don't lint non-statement/faux empty needless_ifs #10935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

Alexendoo
Copy link
Member

Also has a basic fall-back for if statements that have attributes applied to them and incorporates #10921 (review) while I was there

r? @Manishearth

changelog: none

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 12, 2023
@Alexendoo Alexendoo mentioned this pull request Jun 12, 2023
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's still a risk of the macros themselves being cfg-replaced but should be fine

@Manishearth
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 13, 2023

📌 Commit 5e20a57 has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 13, 2023

⌛ Testing commit 5e20a57 with merge 8a1f0cd...

@bors
Copy link
Contributor

bors commented Jun 13, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing 8a1f0cd to master...

@bors bors merged commit 8a1f0cd into rust-lang:master Jun 13, 2023
@Alexendoo Alexendoo deleted the needless-if-cases branch June 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants