Move uninlined_format_args to pedantic
#15287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
samueltardieu
approved these changes
Jul 16, 2025
|
Lintcheck changes for 32263f5
This comment will be updated if you push new changes |
dswij
approved these changes
Jul 16, 2025
rustbot
removed
the
S-waiting-on-review
Alexendoo
added
the
beta-nominated
flip1995
added
beta-accepted
2 tasks
notmandatory
added a commit
to bitcoindevkit/bdk_wallet
that referenced
this pull request
Jul 31, 2025
d75126e clippy: allow `uninlined_format_args` (valued mammal) cbf0cfe chore: update rust-version to 1.88.0 (valued mammal) aa53cc1 clippy: fix uninlined format args (valued mammal) Pull request description: Fix #281 by taking clippy's suggestion to inline the arguments to a `format!` string where applicable. Also update `rust-version` to 1.88.0, closing #280. ### Notes to the reviewers I've gone ahead and fixed the clippy warnings, although some have argued that the lint is quite pedantic and not entirely helpful when it comes to style and readability. Therefore I also allowed the lint to prevent clippy from warning about it in the future d75126e. That change can be reverted if/when rust lang moves `uninlined_format_args` back to the pedantic, i.e. not default group of lints rust-lang/rust-clippy#15287. ### Checklists #### All Submissions: * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [ ] ~~This pull request breaks the existing API~~ ACKs for top commit: notmandatory: ACK d75126e oleonardolima: ACK d75126e Tree-SHA512: c34e701fb08f6ada2b0f34c87c93417ca966b021360fa787563f00c6968444028a876bfaf6952cf468f8ad834556b784002d4fc7fd09886fc7420ff1cb6eff9d
github-merge-queue bot
pushed a commit
to dfinity/ic
that referenced
this pull request
Aug 5, 2025
# Changes 1. Removed long deprecated rls component, since it's been [removed from rust in 1.87.0](rust-lang/rust#126856) 2. disabled [uninlined_format_args](https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args) check - otherwise I would have to change essentially every file in the repo in this PR... - note that the lint[ has been moved back to `pedantic` in the cargo clippy](rust-lang/rust-clippy#15287), so the problem will eventually go away, but it is still an issue in this version of rust (`1.88.0`). See also rust-lang/rust-clippy#15151 3. Explicitly ignored [result_large_err](https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err) warnings - I'll leave it up to the code owners whether/how to fix the warnings 4. Modified the backtrace message in `rs/execution_environment/tests/backtraces.rs` 5. Bumped max compressed wasm size of some nns canisters from 1.5MB to 1.6MB in `file_size_check` tests 6. Fixed [io_other_error](https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error) warnings 7. Fixed [iter_kv_map](https://rust-lang.github.io/rust-clippy/master/index.html#iter_kv_map) warnings 8. Fixed [manual_contains](https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains) warnings 9. Fixed some other, rarely occurring, clippy warnings ## Benchmarks updates ### //rs/ledger_suite/icrc1/ledger:canbench_u256 Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-------------------------------------|-------|---------|---------|-----|--------|-----|---------| | + | bench_icrc1_transfers::post_upgrade | 1 | 365.33M | +3.75% | 71 | 0.00% | 0 | 0.00% | | + | bench_icrc1_transfers::upgrade | 1 | 516.12M | +3.17% | 200 | 0.00% | 128 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change ### //rs/ledger_suite/icrc1/ledger:canbench_u64 Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|--------------------------------------------|-------|--------|---------|----|---------|-----|---------| | + | bench_icrc1_transfers::icrc2_approve | 1 | 18.44B | -0.22% | 29 | +16.00% | 128 | 0.00% | | - | bench_icrc1_transfers::icrc1_transfer | 1 | 12.24B | -0.50% | 31 | -8.82% | 0 | 0.00% | | - | bench_icrc1_transfers::icrc2_transfer_from | 1 | 20.57B | -0.54% | 3 | -25.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change ### //rs/nns/governance:governance-canbench Only significant changes: | status | name | calls | ins | ins Δ% | HI | HI Δ% | SMI | SMI Δ% | |--------|-----------------------------------|-------|--------|---------|----|--------|-----|---------| | + | add_neuron_inactive_maximum | | 64.86M | +5.79% | 0 | 0.00% | 0 | 0.00% | | + | add_neuron_active_maximum_stable | | 64.86M | +5.79% | 0 | 0.00% | 0 | 0.00% | | - | list_neurons_stable | | 63.04M | -5.65% | 9 | 0.00% | 0 | 0.00% | | - | list_neurons_by_subaccount_stable | | 62.12M | -5.67% | 5 | 0.00% | 0 | 0.00% | | - | range_neurons_performance | | 51.56M | -6.28% | 0 | 0.00% | 0 | 0.00% | ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change --------- Co-authored-by: IDX GitHub Automation <> Co-authored-by: IDX GitHub Automation <infra+github-automation@dfinity.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15151
See also https://rust-lang.zulipchat.com/#narrow/channel/257328-clippy/topic/uninlined_format_args.20is.20contentious/
changelog: Move [
uninlined_format_args] topedantic