-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Open
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-metaArea: Issues & PRs about the rust-lang/rust repository itselfArea: Issues & PRs about the rust-lang/rust repository itselfC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.
Description
git grep "[^e]bug\!()" compiler 130
git grep "panic\!()" compiler 43
git grep "unreachable\!()" compiler 384
I wonder if it makes sense to try to fill these up with at least somewhat contextual error/ice messages instead of just a "panicked at" or "impossible case reached"?
Unfortunately I could not find a rustc lint that warns on empty panics like these
davidtwco
Metadata
Metadata
Assignees
Labels
A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustArea: Makes things more difficult for new or seasoned contributors to RustA-metaArea: Issues & PRs about the rust-lang/rust repository itselfArea: Issues & PRs about the rust-lang/rust repository itselfC-cleanupCategory: PRs that clean code up or issues documenting cleanup.Category: PRs that clean code up or issues documenting cleanup.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.