Skip to content

Conversation

weiznich
Copy link
Contributor

@weiznich weiznich commented Nov 9, 2023

This commit adds warnings if a user supplies several diagnostic options where we can only apply one of them. We explicitly warn about ignored options here. In addition a small test for these warnings is added.

r? @compiler-errors

For now that's the last PR to improve the warnings generated by misused #[diagnostic::on_unimplemented] attributes. I'm not sure what needs to be done next to move this closer to stabilization.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 9, 2023
@weiznich
Copy link
Contributor Author

@compiler-errors Is there anything I can do to move this forward?

@bors
Copy link
Collaborator

bors commented Nov 16, 2023

☔ The latest upstream changes (presumably #117875) made this pull request unmergeable. Please resolve the merge conflicts.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me once it's rebased, sorry for the review delay

This commit adds warnings if a user supplies several diagnostic options
where we can only apply one of them. We explicitly warn about ignored
options here. In addition a small test for these warnings is added.
@weiznich weiznich force-pushed the turn_overlapping_diagnostic_options_into_warnings branch from 0b34410 to 10538d4 Compare November 17, 2023 06:29
@weiznich
Copy link
Contributor Author

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 17, 2023

@weiznich: 🔑 Insufficient privileges: Not in reviewers

@weiznich
Copy link
Contributor Author

No worries for taking time to review changes. It was just meant to be a little reminder

@compiler-errors
Copy link
Member

@weiznich: the syntax is @bors r=compiler-errors or something, since you're not approving the PR. But also, you need bors rights, so if I say "r=me when...", it's code for "I will approve it when", not "please invoke bors".

@bors r+

@bors

This comment was marked as outdated.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 17, 2023
@compiler-errors
Copy link
Member

@bors r+

@bors

This comment was marked as outdated.

@bors
Copy link
Collaborator

bors commented Nov 17, 2023

📌 Commit 10538d4 has been approved by compiler-errors

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 18, 2023

⌛ Testing commit 10538d4 with merge 547ace8...

@bors
Copy link
Collaborator

bors commented Nov 18, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 547ace8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 18, 2023
@bors bors merged commit 547ace8 into rust-lang:master Nov 18, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 18, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (547ace8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.1% [1.0%, 5.4%] 3
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.978s -> 676.499s (0.08%)
Artifact size: 313.80 MiB -> 313.81 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants