`tests/ui/issues/`: The Issues Strike Back [3/N] #144400

Kivooeo · 2025-07-24T13:14:01Z

Some tests/ui/issues/ housekeeping, to trim down number of tests directly under tests/ui/issues/. Part of #133895.

rustbot · 2025-07-24T13:14:05Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-07-24T13:14:07Z

This PR modifies tests/ui/issues/. If this PR is adding new tests to tests/ui/issues/,
please refrain from doing so, and instead add it to more descriptive subdirectories.

bors · 2025-07-26T11:26:55Z

☔ The latest upstream changes (presumably #144488) made this pull request unmergeable. Please resolve the merge conflicts.

jieyouxu

Thanks, some nits

jieyouxu · 2025-08-05T12:18:59Z

tests/ui/extern/macro-use-extern-std-14330.rs

Suggestion: yeet this, this was originally testing #![feature(phase)] that was yeeted.

jieyouxu · 2025-08-05T12:58:14Z

tests/ui/lifetimes/return-reference-local-variable-13497-2.rs

Question: does this still need the -2?

jieyouxu · 2025-08-05T13:01:31Z

tests/ui/macros/assert-mismatched-types-14091.rs

Suggestion: remove this test, I'm like 90% sure this already regressed in what it was testing as original reproducer is very whitespace sensitive, i.e. #14091

jieyouxu · 2025-08-05T13:02:20Z

tests/ui/macros/assert-unary-operator-14091-2.rs

Suggestion: also remove, whitespace was changed since a long time ago as well

jieyouxu · 2025-08-05T13:05:11Z

tests/ui/modules/use-shadowing-14082.rs

Suggestion: resolve/

jieyouxu · 2025-08-05T13:31:05Z

tests/ui/pattern/array-length-mismatch-verbose-13482-2.rs

Nit: don't need the -2 then

jieyouxu · 2025-08-05T13:33:47Z

tests/ui/traits/generic-trait-bound-14382.rs

Suggestion: inference/.

This test was moved by @Oneirical and it's now tests/ui/type-inference/float-type-inference-unification-14382.rs so I keep it as it

Uh if that's the case, yeet this duplicate test

After I did git pull --rebase to remove conflicts its already unified our tests and keep their, so I just removed their comment from bottom, imo type-inference/ is fine here (https://github.com/rust-lang/rust/pull/144400/files#diff-385ae3df0488b90afc0e919de63c4398ae3f831569ce53818649706c5349afb8)

jieyouxu · 2025-08-05T13:34:25Z

tests/ui/traits/matcher-lifetime-inference-14919.rs

Suggestion: inference/

jieyouxu · 2025-08-05T13:35:02Z

tests/ui/traits/pointer-type-impls-14254.rs

Suggestion: resolve/

jieyouxu · 2025-08-05T13:36:15Z

tests/ui/traits/reader-wrapper-trait-14901.rs

Suggestion: maybe lifetimes/ or bounds/ if we have such directory

Kivooeo · 2025-08-06T23:37:41Z

@rustbot ready

jieyouxu

Thanks

jieyouxu · 2025-08-07T13:03:22Z

@bors r+ rollup

bors · 2025-08-07T13:03:25Z

📌 Commit b6e13e3 has been approved by jieyouxu

It is now in the queue for this repository.

`tests/ui/issues/`: The Issues Strike Back [3/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? `@jieyouxu`

Rollup of 6 pull requests Successful merges: - #144400 (`tests/ui/issues/`: The Issues Strike Back [3/N]) - #144678 (Make no_mangle on foreign items explicit instead of implicit) - #145045 (doc(library): Fix Markdown in `Iterator::by_ref`) - #145046 (Fix doc comment of File::try_lock and File::try_lock_shared) - #145047 (move `type_check` out of `compute_regions`) - #145053 (Add a lot of NLL `known-bug` tests) r? `@ghost` `@rustbot` modify labels: rollup

`tests/ui/issues/`: The Issues Strike Back [3/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of rust-lang#133895. r? ``@jieyouxu``

Rollup of 19 pull requests Successful merges: - #144400 (`tests/ui/issues/`: The Issues Strike Back [3/N]) - #144764 ([codegen] assume the tag, not the relative discriminant) - #144807 (Streamline config in bootstrap) - #144899 (Print CGU reuse statistics in `-Zprint-mono-items`) - #144909 (Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information) - #144912 (Resolver: introduce a conditionally mutable Resolver for (non-)speculative resolution.) - #144914 (Add support for `ty::Instance` path shortening in diagnostics) - #144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - #144999 (coverage: Remove all unstable support for MC/DC instrumentation) - #145009 (A couple small changes for rust-analyzer next-solver work) - #145030 (GVN: Do not flatten derefs with ProjectionElem::Index. ) - #145042 (stdarch subtree update) - #145047 (move `type_check` out of `compute_regions`) - #145051 (Prevent name collisions with internal implementation details) - #145053 (Add a lot of NLL `known-bug` tests) - #145055 (Move metadata symbol export from exported_non_generic_symbols to exported_symbols) - #145057 (Clean up some resolved test regressions of const trait removals in std) - #145068 (Readd myself to review queue) - #145070 (Add minimal `armv7a-vex-v5` tier three target) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #144400 - Kivooeo:issue3, r=jieyouxu `tests/ui/issues/`: The Issues Strike Back [3/N] Some `tests/ui/issues/` housekeeping, to trim down number of tests directly under `tests/ui/issues/`. Part of #133895. r? ```@jieyouxu```

Rollup of 19 pull requests Successful merges: - rust-lang/rust#144400 (`tests/ui/issues/`: The Issues Strike Back [3/N]) - rust-lang/rust#144764 ([codegen] assume the tag, not the relative discriminant) - rust-lang/rust#144807 (Streamline config in bootstrap) - rust-lang/rust#144899 (Print CGU reuse statistics in `-Zprint-mono-items`) - rust-lang/rust#144909 (Add new `test::print_merged_doctests_times` used by rustdoc to display more detailed time information) - rust-lang/rust#144912 (Resolver: introduce a conditionally mutable Resolver for (non-)speculative resolution.) - rust-lang/rust#144914 (Add support for `ty::Instance` path shortening in diagnostics) - rust-lang/rust#144931 ([win][arm64ec] Fix msvc-wholearchive for Arm64EC) - rust-lang/rust#144999 (coverage: Remove all unstable support for MC/DC instrumentation) - rust-lang/rust#145009 (A couple small changes for rust-analyzer next-solver work) - rust-lang/rust#145030 (GVN: Do not flatten derefs with ProjectionElem::Index. ) - rust-lang/rust#145042 (stdarch subtree update) - rust-lang/rust#145047 (move `type_check` out of `compute_regions`) - rust-lang/rust#145051 (Prevent name collisions with internal implementation details) - rust-lang/rust#145053 (Add a lot of NLL `known-bug` tests) - rust-lang/rust#145055 (Move metadata symbol export from exported_non_generic_symbols to exported_symbols) - rust-lang/rust#145057 (Clean up some resolved test regressions of const trait removals in std) - rust-lang/rust#145068 (Readd myself to review queue) - rust-lang/rust#145070 (Add minimal `armv7a-vex-v5` tier three target) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Jul 24, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 24, 2025

Kivooeo force-pushed the issue3 branch from 53661bd to 871b2f0 Compare July 25, 2025 10:24

jieyouxu requested changes Aug 5, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 5, 2025

Kivooeo added 2 commits August 5, 2025 19:02

moved 35 tests to organized locations

62c92f3

comments

b6e13e3

Kivooeo force-pushed the issue3 branch from 871b2f0 to b6e13e3 Compare August 5, 2025 14:35

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 6, 2025

jieyouxu approved these changes Aug 7, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2025

tgross35 mentioned this pull request Aug 7, 2025

Rollup of 6 pull requests #145062

Closed

Zalathar mentioned this pull request Aug 8, 2025

Rollup of 19 pull requests #145077

Merged

bors merged commit cb271d0 into rust-lang:master Aug 8, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 8, 2025

tests/ui/issues/: The Issues Strike Back [3/N] #144400

tests/ui/issues/: The Issues Strike Back [3/N] #144400

Conversation

Kivooeo commented Jul 24, 2025

Uh oh!

rustbot commented Jul 24, 2025

Uh oh!

rustbot commented Jul 24, 2025

Uh oh!

bors commented Jul 26, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kivooeo commented Aug 6, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 7, 2025

Uh oh!

bors commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

`tests/ui/issues/`: The Issues Strike Back [3/N] #144400

`tests/ui/issues/`: The Issues Strike Back [3/N] #144400