Additional tce tests #144650
Open
Additional tce tests #144650
+300
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd the LLVM codegen backend.
|
|
rustbot
added
A-LLVM
|
Some changes occurred in compiler/rustc_codegen_ssa Some changes occurred in compiler/rustc_codegen_gcc |
This comment has been minimized.
This comment has been minimized.
Borgerr
force-pushed
the
additional-tce-tests
branch
from
cdfbab1 to
06db3a5
Compare
This comment has been minimized.
This comment has been minimized.
Borgerr
force-pushed
the
additional-tce-tests
branch
from
06db3a5 to
0dba4bb
Compare
This comment has been minimized.
This comment has been minimized.
|
You're gonna need the kind of //@normalize-stderr attributes as other ICE tests have, or just add the test to tests/crashes |
Borgerr
force-pushed
the
additional-tce-tests
branch
from
0dba4bb to
e0738ad
Compare
This comment has been minimized.
This comment has been minimized.
Borgerr
force-pushed
the
additional-tce-tests
branch
from
e0738ad to
e0b4595
Compare
Comment on lines
+1
to
+3
| // Indexing taken from | ||
| // https://github.com/phi-go/rfcs/blob/guaranteed-tco/text%2F0000-explicit-tail-calls.md#tail-call-elimination | ||
| // should probably come back to after some decision on verbiage |
There was a problem hiding this comment.
What do you mean by "decision on verbiage"?.. What is this test even testing?
you can make the test pass (hopefully) by just replacing &dyn Fn(usize) with fn(usize)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @oli-obk
Adds known-bug tests for LLVM emissions regarding indirect operands for TCE. Also includes a test,
indexer.rs, referring to function_table behavior described by the RFC.Depends on #144232
Closes #144293