Rename and document `ONLY_HOSTS` in bootstrap #145324

Kobzol · 2025-08-12T20:17:22Z

Everytime I examined the ONLY_HOSTS flag of bootstrap steps, I was utterly confused. Why is it called ONLY_HOSTS? How does the fact that it is skipped if --target is passed, but --host is not (which was not accurate) help me?

The reality of the flag is that if it is true, the targets for which the given Step will be built is determined based on the --host flag, while if it is false, it is determined based on the --target flag, that's pretty much it. The previous comment was just a (not very helpful and not even accurate) corollary of that.

I clarified the comment, and also renamed the flag to IS_HOST (happy to brainstorm better names, but the doc. comment change is IMO the main improvement).

r? @jieyouxu

rustbot · 2025-08-12T20:17:27Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-08-12T20:17:30Z

This PR changes how GCC is built. Consider updating src/bootstrap/download-ci-gcc-stamp.

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

jieyouxu

Hm yeah, the --{host,target} situation feels rather confusing... Thanks

jieyouxu · 2025-08-13T01:00:44Z

@bors r+ rollup=never (I feel like this will conflict with other bootstrap PRs)

bors · 2025-08-13T01:00:47Z

📌 Commit a43def7 has been approved by jieyouxu

It is now in the queue for this repository.

jieyouxu · 2025-08-13T13:04:02Z

Hm but maybe let's see
@bors rollup

…ouxu Rename and document `ONLY_HOSTS` in bootstrap Everytime I examined the `ONLY_HOSTS` flag of bootstrap steps, I was utterly confused. Why is it called ONLY_HOSTS? How does the fact that it is skipped if `--target` is passed, but `--host` is not (which was not accurate) help me? The reality of the flag is that if it is true, the targets for which the given Step will be built is determined based on the `--host` flag, while if it is false, it is determined based on the `--target` flag, that's pretty much it. The previous comment was just a (not very helpful and not even accurate) corollary of that. I clarified the comment, and also renamed the flag to `IS_HOST` (happy to brainstorm better names, but the doc. comment change is IMO the main improvement). r? `@jieyouxu`

GuillaumeGomez · 2025-08-13T16:11:10Z

I wonder if this is the one which failed in #145363 ?

Kobzol · 2025-08-13T20:43:06Z

Unlikely, this only renamed a const item.

bors · 2025-08-14T00:06:46Z

☔ The latest upstream changes (presumably #145366) made this pull request unmergeable. Please resolve the merge conflicts.

Rollup of 13 pull requests Successful merges: - #122661 (Change the desugaring of `assert!` for better error output) - #142372 (Improve `--remap-path-prefix` documentation) - #143075 (compiler: Allow `extern "interrupt" fn() -> !`) - #145005 (strip prefix of temporary file names when it exceeds filesystem name length limit) - #145065 (resolve: Introduce `RibKind::Block`) - #145120 (llvm: Accept new LLVM lifetime format) - #145189 (Weekly `cargo update`) - #145261 (Improve tracing in bootstrap) - #145266 (Reduce some queries around associated items) - #145299 (doc test: fix mpsc.rs try_send doc test) - #145331 (Make std use the edition 2024 prelude) - #145353 (bootstrap: Fix jemalloc 64K page support for aarch64 tools) - #145361 (Suppress wrapper suggestion when expected and actual ty are the same adt and the variant is unresolved) Failed merges: - #145324 (Rename and document `ONLY_HOSTS` in bootstrap) - #145372 (resolve: Miscellaneous cleanups) r? `@ghost` `@rustbot` modify labels: rollup

…nd had no comment

Kobzol · 2025-08-14T14:58:59Z

@bors r=jieyouxu

Rebased.

bors · 2025-08-14T14:59:03Z

📌 Commit e08c755 has been approved by jieyouxu

It is now in the queue for this repository.

…ouxu Rename and document `ONLY_HOSTS` in bootstrap Everytime I examined the `ONLY_HOSTS` flag of bootstrap steps, I was utterly confused. Why is it called ONLY_HOSTS? How does the fact that it is skipped if `--target` is passed, but `--host` is not (which was not accurate) help me? The reality of the flag is that if it is true, the targets for which the given Step will be built is determined based on the `--host` flag, while if it is false, it is determined based on the `--target` flag, that's pretty much it. The previous comment was just a (not very helpful and not even accurate) corollary of that. I clarified the comment, and also renamed the flag to `IS_HOST` (happy to brainstorm better names, but the doc. comment change is IMO the main improvement). r? `@jieyouxu`

Rollup of 11 pull requests Successful merges: - #137872 (Include whitespace in "remove |" suggestion and make it hidden) - #144631 (Fix test intrinsic-raw_eq-const-bad for big-endian) - #145233 (cfg_select: Support unbraced expressions) - #145261 (Improve tracing in bootstrap) - #145324 (Rename and document `ONLY_HOSTS` in bootstrap) - #145353 (bootstrap: Fix jemalloc 64K page support for aarch64 tools) - #145379 (bootstrap: Support passing `--timings` to cargo) - #145397 (Rust documentation, use `rustc-dev-guide` :3) - #145398 (Use `default_field_values` in `Resolver`) - #145401 (cleanup: Remove useless `[T].iter().last()`) - #145403 (Adjust error message grammar to be less awkward) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145324 - Kobzol:bootstrap-host-only, r=jieyouxu Rename and document `ONLY_HOSTS` in bootstrap Everytime I examined the `ONLY_HOSTS` flag of bootstrap steps, I was utterly confused. Why is it called ONLY_HOSTS? How does the fact that it is skipped if `--target` is passed, but `--host` is not (which was not accurate) help me? The reality of the flag is that if it is true, the targets for which the given Step will be built is determined based on the `--host` flag, while if it is false, it is determined based on the `--target` flag, that's pretty much it. The previous comment was just a (not very helpful and not even accurate) corollary of that. I clarified the comment, and also renamed the flag to `IS_HOST` (happy to brainstorm better names, but the doc. comment change is IMO the main improvement). r? ``@jieyouxu``

rustbot assigned jieyouxu Aug 12, 2025

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 12, 2025

jieyouxu approved these changes Aug 13, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 13, 2025

jieyouxu mentioned this pull request Aug 13, 2025

Split codegen backend check step into two and don't run it with x check compiler #145340

Open

GuillaumeGomez mentioned this pull request Aug 13, 2025

Rollup of 11 pull requests #145363

Closed

Zalathar mentioned this pull request Aug 14, 2025

Rollup of 13 pull requests #145373

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 14, 2025

Kobzol added 2 commits August 14, 2025 16:58

Remove ONLY_HOSTS value overrides that just set the default value a…

f382d54

…nd had no comment

Rename and document ONLY_HOSTS in bootstrap

e08c755

Kobzol force-pushed the bootstrap-host-only branch from a43def7 to e08c755 Compare August 14, 2025 14:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 14, 2025

This was referenced Aug 14, 2025

Rollup of 12 pull requests #145406

Closed

Rollup of 11 pull requests #145407

Merged

bors merged commit 06246bf into rust-lang:master Aug 15, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 15, 2025

Kobzol deleted the bootstrap-host-only branch August 15, 2025 05:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename and document `ONLY_HOSTS` in bootstrap #145324

Rename and document `ONLY_HOSTS` in bootstrap #145324

Kobzol commented Aug 12, 2025 •

edited

Loading

Uh oh!

rustbot commented Aug 12, 2025

Uh oh!

rustbot commented Aug 12, 2025

Uh oh!

jieyouxu left a comment

Uh oh!

jieyouxu commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

jieyouxu commented Aug 13, 2025

Uh oh!

GuillaumeGomez commented Aug 13, 2025

Uh oh!

Kobzol commented Aug 13, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

Kobzol commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Rename and document ONLY_HOSTS in bootstrap #145324

Rename and document ONLY_HOSTS in bootstrap #145324

Conversation

Kobzol commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Aug 12, 2025

Uh oh!

rustbot commented Aug 12, 2025

Uh oh!

jieyouxu left a comment

Choose a reason for hiding this comment

Uh oh!

jieyouxu commented Aug 13, 2025

Uh oh!

bors commented Aug 13, 2025

Uh oh!

jieyouxu commented Aug 13, 2025

Uh oh!

GuillaumeGomez commented Aug 13, 2025

Uh oh!

Kobzol commented Aug 13, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

Kobzol commented Aug 14, 2025

Uh oh!

bors commented Aug 14, 2025

Uh oh!

Uh oh!

Uh oh!

Rename and document `ONLY_HOSTS` in bootstrap #145324

Rename and document `ONLY_HOSTS` in bootstrap #145324

Kobzol commented Aug 12, 2025 •

edited

Loading