rustbot always thinks @oli-obk is a new contributor

[saethlin]

Reporting this because the bot also failed to ping rust-lang/miri here: rust-lang/rust#109938 (comment)

Examples of the bot thinking @oli-obk is a new contributor:

rust-lang/rust#109938
rust-lang/rust#109115
rust-lang/rust#108860
rust-lang/rust#110315

It looks like maybe all the cases where Oli doesn't get the welcome message are PRs that start with a r? @ghost in the PR description.

[oli-obk]

I tried fixing this by setting a correct email address in rust-lang/rust#108035 but it turns out github doesn't grok their own custom address either. So I'd need to change that again or make a commit with it.

[ehuss]

It looks to be some issue on GitHub's side. https://api.github.com/repos/rust-lang/rust/commits?author=oli-obk is returning an empty array. I don't see anything obvious to explain why (the commit objects using other queries like https://api.github.com/repos/rust-lang/rust/commits?sha=241c6a4a616010382aefe297c69a26fb5a22dd06 clearly show the author field as "oli-obk"). Maybe it is caused by the large number of mailmap entries? Or maybe changes in their email address had issues with the index? I'm not sure how GitHub maps commits to GitHub accounts.

We may need to change it back to use the search endpoint (/search/commits?q=repo:rust-lang/rust+author:oli-obk), which seems to work correctly.

[Noratrieb]

@durin42 is experiencing the same welcomingness: rust-lang/rust#110455 (comment)

[ehuss]

@Nilstrieb I think their email address does not match their email address in GitHub, so it is not possible to know if they have committed before or not.

[RalfJung]

@rytheo seems to also be "always new": rust-lang/rust#114257

[ehuss]

Posted #1713 with a fix which seems to work for both rytheo and oli-obk.