Avoid Event enum in examples
#277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
force-pushed
the
madsmtm/simpler-examples
branch
from
e277283 to
58af263
Compare
MarijnS95
reviewed
Aug 13, 2025
| Event::WindowEvent { window_id, event }, | ||
| event_loop, | ||
| ); | ||
| (self.event)(state, surface_state, window_id, event, event_loop); |
There was a problem hiding this comment.
User code compared the window_id (good practice even though we don't open multiple windows iirc). Can we do that here based on the window, or don't we have it yet (hard to tell from a phone screen, is it the sometimes-unused T generic argument)?
There was a problem hiding this comment.
I could add a:
if window_id != window.id() {
return;
}branch if you want? It just seems needless IMO for single-window applications.
There was a problem hiding this comment.
Doing so sets a good example, especially if you can do it nicely isolated in one place now? Perhaps then we no longer need to pass it into the closure, nothing seems to use it right?
|
LGTM except for the Clippy warning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is removed in the next Winit version, and it forces needless indentation in the examples.