Skip to content

Add sort to search #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2025
Merged

Add sort to search #6

merged 1 commit into from
May 30, 2025

Conversation

keoghpe
Copy link
Contributor

@keoghpe keoghpe commented May 29, 2025

  • Removes duration from search tool description (looks inaccurate according to the Slack docs)
  • Allows search to sort ascending or descending
  • Removes filtering of current message from getting the thread replies
  • Gives more explicit instruction for the thread replies timestamp

@keoghpe keoghpe marked this pull request as ready for review May 29, 2025 15:52
@@ -143,7 +143,8 @@ export async function getSlackThreadReplies(channel: string, ts: string, limit?:
limit,
});

const messages = response.messages?.filter((msg) => msg.ts !== ts) || [];
// const messages = response.messages?.filter((msg) => msg.ts !== ts) || [];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can just delete this

- Removes duration from search tool description (looks inaccurate according to the Slack docs)
- Allows search to sort ascending or descending
- Removes filtering of current message from getting the thread replies
- Gives more explicit instruction for the thread replies timestamp
@rygwdn rygwdn merged commit d26e671 into rygwdn:main May 30, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants