Skip to content

mp3 version of Pencil sound for Windows OS #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

QubaB
Copy link
Contributor

@QubaB QubaB commented Jul 16, 2025

Added mp3 version of pencil sound. On Windows is ogg nonstandard audio format.

Copy link

codecov bot commented Jul 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.10%. Comparing base (4eba05f) to head (7cc901e).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1492      +/-   ##
==========================================
+ Coverage   46.09%   46.10%   +0.01%     
==========================================
  Files         117      117              
  Lines        8685     8685              
==========================================
+ Hits         4003     4004       +1     
+ Misses       4682     4681       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adil192
Copy link
Member

adil192 commented Jul 17, 2025

On Windows is ogg nonstandard audio format

Does the ogg not work or is this just a preference?
Mp3 is generally a bad format for looping audios because it has silent gaps at each end.

@QubaB
Copy link
Contributor Author

QubaB commented Jul 18, 2025

On my Windows (I have not installed any additional codecs) is ogg format unsupported. Wav can be used instead mp3 if it is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants