Add quick fix to remove unnecessary .nn #23461
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olhotak
reviewed
Jul 2, 2025
| override def explain(using Context) = { | ||
| val code1 = """val a: String = "foo".nn""" | ||
| val code2 = """val a: String = "foo"""" | ||
| i"""With -Yexplicit-nulls, this happens when use apply .nn to a term that is already non-null. |
There was a problem hiding this comment.
Depending on the reason, this may not be accurate: it could also be because you're applying .nn to a nullable term in a context that admits a nullable term.
I'd suggest changing reason to a Boolean, then have all the strings in this class, in the implementation of msg and explain.
There was a problem hiding this comment.
Perhaps explain isn't really necessary at all. (?)
There was a problem hiding this comment.
I've gone and removed the explain, but I'll keep this comment thread open just in case someone comes along and has another idea.
olhotak
reviewed
Jul 4, 2025
olhotak
approved these changes
Jul 4, 2025
noti0na1
added a commit
that referenced
this pull request
Aug 13, 2025
An extension to #23461 that adds a quick fix to add a .nn. For example, if the code were ```scala val t: String | Null = ??? val s: String = t ``` the quick fix would transform the code to: ```scala val t: String | Null = ??? val s: String = t.nn ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An addition to #23327 that adds a quick fix to remove unnecessary .nn's.