Add -I <Interval>, Remove -o <offset>, and Refactor -n #521
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tjerbor
changed the title
|
I quite like this overall, except of the syntax. I would just use a more human way: scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 10-36
scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I -36
scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 10-
scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 123 # for only one track. With the other refactoring going on, I am not sure if this will ever get merged. |
# Conflicts: # .gitignore # scdl/scdl.py
…hout hyphen is given.
I changed it to this syntax and also added the support to download a single track as shown in your example. You can use my fork in the meantime.
I switched to yt-dlp some months ago because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue.
The Interval option allows to download a subset of a Playlist or all User options.
It is compatible with all other options including --download-archive, --sync, and -n.
It can be used like this:
scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 10-36scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I -36scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 10-scdl -l https://soundcloud.com/one-thousand-and-one/sets/playlist1 -I 10The interval bounds are inclusive.
Indexing starts from 1.
The option supports left- and right-unbounded intervals.
Since a right-unbounded interval equals a skip function, the offset option can be safely removed.
If only one number without hyphen is given, then the single track at that index will be downloaded.
The original recency sorting -n has been refactored to just -n to avoid clashing track limits.
Some tests are currently broken.