Frontend compatibilty fixes #420
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR implements frontend compatibility changes by modifying the challenge fetching approach from loading all challenges at once to first fetching challenge metadata and then individual challenges on demand. The API now provides different response structures for regular users (ChallengeResp) versus admins (AdminChallengeResp).
- Updates TOML configuration field names from snake_case to camelCase (e.g.,
dynamic_flag→dynamicFlag) - Adds new database functions for metadata-only queries and challenge solve statistics
- Implements time-series data aggregation for leaderboard graphs with configurable time buckets
- Refactors API endpoints to return structured challenge metadata vs full challenge details
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| templates/templates.go | Updates template field names from snake_case to camelCase |
| core/utils/cleanup.go | Adds comment about leaderboard cache persistence |
| core/manager/utils.go | Adds difficulty field handling with default value |
| core/database/user.go | Adds function to query unique challenge tags |
| core/database/tag.go | Adds metadata-only query function for related challenges |
| core/database/challenges.go | Adds multiple new functions for metadata queries, solve statistics, and time-series data |
| core/constants.go | Adds leaderboard graph size constant |
| core/config/challenge.go | Updates TOML field names to camelCase and adds difficulty field |
| api/router.go | Updates route handlers and adds new endpoints |
| api/response.go | Restructures response types for challenge metadata and details |
| api/info.go | Major refactor of challenge info handlers to use new metadata approach |
| api/admin.go | Updates cache invalidation logic |
| _examples/ | Updates example TOML files to use new camelCase field names |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
@sukhman-sukh , I have added some comments. Please go through them
|
|
||
| users, err := database.GetRelatedUsers(&challenge) | ||
| if len(challenges) > 0 && challenges[0].Status != "Undeployed" { |
There was a problem hiding this comment.
Instead of using raw strings, please prefer enum types
| @@ -417,84 +393,34 @@ func challengesInfoHandler(c *gin.Context) { | |||
| } | |||
|
|
|||
| for index, challenge := range challenges { | |||
| users, err := database.GetRelatedUsers(&challenge) | |||
| if challenge.Status == "Undeployed" && user.Role == core.USER_ROLES["contestant"] { | |||
|
|
||
| func getLeaderboardGraphHandler(c *gin.Context) { | ||
| var topUsers []uint | ||
| // TODO: Add a check for leaderboard stale to prevent stale graphs |
There was a problem hiding this comment.
Please explain what's going on here.
| if !graphCacheStale || isLeaderboardFrozen { | ||
| c.JSON(http.StatusOK, graphCache) | ||
| } else { | ||
| // TODO: Add a fallback for frozen leaderboard as graphcache is in memory and not persistent. SO, might get lost if server got down in between. |
There was a problem hiding this comment.
Please make an issue for this if not already done
Backend changes for frontend compatibility.
In this PR, Major update is changing the challenge fetching from fetching all the challenges at once to first fetching
ChallengeMetdataand then fetch individual challenges one by one as needed. The client getsChallengeRespwhereas the admin getsAdminChallengeResp.