Skip to content

fix: Check failCommentCondition in "success" step #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

rhys-childs
Copy link

@rhys-childs rhys-childs commented Apr 14, 2025

This pull request add the config property failCommentCondition to the fail check in the success step of the release cycle.

Related Issue

Fixes #1025

Copy link
Member

@babblebey babblebey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @rhys-childs 😉,

Thank you and congrats on making your first contribution to the project 🥳

@babblebey babblebey requested review from travi and jedwards1211 April 14, 2025 18:41
Copy link
Contributor

@jedwards1211 jedwards1211 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@rhys-childs
Copy link
Author

rhys-childs commented Apr 14, 2025

Thanks for the approvals! Let me know if there’s anything else needed. Otherwise, would someone be able to merge this when they get a chance? Looks like GitHub isn’t giving me merge access.

@babblebey
Copy link
Member

Maybe we can group this with the release on beta branch to @travi ??

@travi
Copy link
Member

travi commented Jul 25, 2025

@babblebey sorry, i admit that i havent given this one much attention since i thought it was in the process of being accepted already.

Maybe we can group this with the release on beta branch

is there anything breaking about this change that would need to be grouped with the other in-process breaking changes? if not, i'd say go ahead and merge into main to just get this out as a stable release

@babblebey
Copy link
Member

babblebey commented Jul 25, 2025

Haha yea, should've accepted immediately yea.

is there anything breaking about this change that would need to be grouped with the other in-process breaking changes?

No breaking changes here.

@travi
Copy link
Member

travi commented Jul 25, 2025

sounds good. i'd say lets go ahead and get this merged then. if you can coordinate that, i'm hoping to direct my attention to OIDC progress in semantic-release/npm#958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

failCommentCondition isnt checked for "success" step
4 participants