-
Notifications
You must be signed in to change notification settings - Fork 141
fix: Check failCommentCondition in "success" step #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix: Check failCommentCondition in "success" step #1026
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch @rhys-childs 😉,
Thank you and congrats on making your first contribution to the project 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can group this with the release on |
@babblebey sorry, i admit that i havent given this one much attention since i thought it was in the process of being accepted already.
is there anything breaking about this change that would need to be grouped with the other in-process breaking changes? if not, i'd say go ahead and merge into main to just get this out as a stable release |
sounds good. i'd say lets go ahead and get this merged then. if you can coordinate that, i'm hoping to direct my attention to OIDC progress in semantic-release/npm#958 |
This pull request add the config property
failCommentCondition
to thefail
check in thesuccess
step of the release cycle.Related Issue
Fixes #1025