Update whatsapp_message.py #139
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Specific Handling of PDF generation for DOCUMENT Headed Messages as per WhatsApp API.
Closed
| } | ||
| }] | ||
| }) | ||
| if template.header_type == "IMAGE": |
There was a problem hiding this comment.
We already send document from Whatsapp Notifications.
There was a problem hiding this comment.
But not from "Send to WhatsApp" in the Frappe UI, hence why sending generates errors as per #138
There was a problem hiding this comment.
But you should ignore if there is a document already sent. This might break if there are notifications set.
There was a problem hiding this comment.
Or else handle this in send_template white listed method.
There was a problem hiding this comment.
I think the user expects manually sending the message via UI to not be overriden by Notification Logic?
|
Stale pull request message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Specific Handling of PDF generation for DOCUMENT Headed Messages as per WhatsApp API.