Feat/add migratation guide 2.0 #115
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dovchik
requested review from
asein-sinch,
JPPortier and
matsk-sinch
as code owners
asein-sinch
reviewed
May 13, 2025
There was a problem hiding this comment.
Can you also add a paragraph for the deprecated endpoints?
There was a problem hiding this comment.
Can you also add some text explaining the rationale behind this refactoring?
|
|
||
| If you are coming from version 1.*, you can see how to use |
There was a problem hiding this comment.
Is this paragraph complete? It feels like this sentence is missing some parts
| # Migration to 2.0 | ||
|
|
||
| ## Content list: | ||
| - [Initialize with unified credentials](#initialize-sinchclient-with-unified-credentials) |
There was a problem hiding this comment.
The TOC title doesn't match with the paragraph title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://tickets.sinch.com/browse/DEVEXP-901
README.md snippets wll be updated in a separate PR