added support for otlp headers #3201
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aminu 'Seun Joshua <seun.aminujoshua@gmail.com>
|
Did anyone try this without any code changes? I think the opentelemetry crate already checks some of the standard env vars... |
|
Yeah, looks like they all are checked. Judging by the code base. |
Comment on lines
+7
to
+14
| use crate::env::OtelExporterOtlpHeaders; | ||
|
|
||
| /// Injects the current W3C TraceContext into the provided request. | ||
| pub fn inject_trace_context<'a>(req: impl Into<HeaderInjector<'a>>) { | ||
| let mut injector = req.into(); | ||
| for (key, value) in OtelExporterOtlpHeaders::headers() { | ||
| injector.set(&key, value); | ||
| } |
There was a problem hiding this comment.
We wouldn't want to inject the headers here. This is for propagating context to outgoing requests. OTEL_EXPORTER_OTLP_TRACES_HEADERS is for setting headers on requests made to the OTel collector to export traces.
|
It respects it, I ran it on main and was able to see the key-pair data parsed into the header. sample env data provided: export OTEL_EXPORTER_OTLP_TRACES_HEADERS="authorization=Bearer trace-token,x-trace-id=abc123"result: Apologies for the late response cc: @calebschoepp |
seun-ja
deleted the
add-support-for-otel-exporter-otlp-trace-logs-metrics-header
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2811