Skip to content

#1058: Migrate test-support Module to JUnit5 #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

etrandafir93
Copy link
Contributor

implements #1058

@etrandafir93
Copy link
Contributor Author

hey @jzheaux, here's my PR!

I've used the org.springframework.util.Assert here instead of a JUnit-specific one, which I think is much better because we no longer need JUnit as a provided dependency - now removed.

Apart from this, I have performed some minor refactoring of the tests and assertions (see the 2nd commit).
Let me know what you think!

@jzheaux jzheaux self-assigned this Aug 14, 2025
@jzheaux jzheaux added this to the 4.0.0-M2 milestone Aug 14, 2025
Issue spring-projectsgh-1058

Signed-off-by: etrandafir93 <emanueltrandafir1993@gmail.com>
@jzheaux jzheaux force-pushed the dev/1058-test_support_junit5 branch from 6204576 to ec9e5c0 Compare August 14, 2025 15:38
@jzheaux jzheaux merged commit d48508f into spring-projects:main Aug 14, 2025
2 checks passed
@jzheaux
Copy link
Collaborator

jzheaux commented Aug 14, 2025

Thanks, @etrandafir93! This is now merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants