Skip to content

Conversation

ilgrosso
Copy link
Contributor

@ilgrosso ilgrosso commented Aug 9, 2019

Following discussion at #7222 , OAuth2LoginSpec#securityContextRepository was added.

@ilgrosso
Copy link
Contributor Author

ilgrosso commented Aug 9, 2019

Travis CI failed because:

A problem occurred configuring project ':spring-security-samples-xml-gae'.
> Could not resolve all artifacts for configuration ':spring-security-samples-xml-gae:classpath'.
   > Could not resolve com.google.cloud.tools:appengine-gradle-plugin:1.3.5.
     Required by:
         project :spring-security-samples-xml-gae
      > Could not resolve com.google.cloud.tools:appengine-gradle-plugin:1.3.5.
         > Could not get resource 'https://repo.maven.apache.org/maven2/com/google/cloud/tools/appengine-gradle-plugin/1.3.5/appengine-gradle-plugin-1.3.5.pom'.
            > Could not HEAD 'https://repo.maven.apache.org/maven2/com/google/cloud/tools/appengine-gradle-plugin/1.3.5/appengine-gradle-plugin-1.3.5.pom'. Received status code 403 from server: Forbidden

which is clearly not related to the proposed changes.

Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ilgrosso! I've left some feedback inline.

Also, would you please change the format of your commit so that it looks more like:

Title

Fixes gh-7222

Where the title briefly describes what was done.

@jzheaux jzheaux self-assigned this Aug 9, 2019
@jzheaux jzheaux added in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Aug 9, 2019
@jzheaux jzheaux added this to the 5.2.0.RC1 milestone Aug 9, 2019
@ilgrosso
Copy link
Contributor Author

@jzheaux please take a look again and let me know, thx

@jzheaux jzheaux changed the title Fix for #7222 Add OAuth2LoginSpec#securityContextRepository Aug 10, 2019
@jzheaux jzheaux merged commit 0410bac into spring-projects:master Aug 10, 2019
@jzheaux
Copy link
Contributor

jzheaux commented Aug 10, 2019

Thanks, @ilgrosso! This is now merged into master.

@ilgrosso
Copy link
Contributor Author

Cool, thx for review @jzheaux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: oauth2 An issue in OAuth2 modules (oauth2-core, oauth2-client, oauth2-resource-server, oauth2-jose) status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants