Split OpSpec and OpImpl #199
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a no-op renaming of things.
Before:
This PR creates two distinct concepts:
OpSpec
: the old OpImpl: it's what the user returns, and it's a "high-level, non-typechecked" description of how to implement an op. Usually, "call this func with these args"OpImpl
is the old W_FuncAdapter, to underline that it's the concrete way to execute an op