-
Notifications
You must be signed in to change notification settings - Fork 68
Fix type sqlite3session_attach
, that accepts 0
for tableName
arg
#78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note that the That said, @tomayac is the overseer of the typescript-related stuff, so it's his call as to whether that design decision applies here. |
@sgbeal I am not changing the number of arguments. But I did make a typo with the union (fixed now). I'm not sure if |
Ah, indeed, my apologies. i completely misunderstood the patch to be providing a default of 0. |
Yes, it will. The JS-to-WASM conversion transforms null and undefined to integer 0 for pointer-passing purposes (wasm uses 32-bit ints for addresses). |
Going with |
@louwers May I ask for the use case? Thank you |
@louwers Interesting. Thinking whether I could use that to speed up reactive queries in https://github.com/evoluhq/evolu |
is the easiest way to monitor all tables for changes. But this is not type-correct. This PR fixes that.