update to use embebing 2 in order to support new versions of Flutter #266
Conversation
|
|
| cardEntryModule = null; | ||
| googlePayModule = null; | ||
| channel = null; |
There was a problem hiding this comment.
Do we still need these three lines? Is the issue resolved that required this workaround?
| public void onAttachedToEngine(FlutterPluginBinding binding) { | ||
| this.applicationContext = binding.getApplicationContext(); | ||
| channel = new MethodChannel(binding.getBinaryMessenger(), "square_in_app_payments"); | ||
| // MethodCallHandler is set in onAttachedToActivity to avoid NPE issues |
There was a problem hiding this comment.
nit: is this going to be a valuable comment in 6 months?
I assume onAttachedTo... are Flutter things, and if the change described is for an NPE, it sounds as though the "normal" thing (no comment needed) should be to move this to the attach-to-activity moment?
| googlePayModule.attachActivityResultListener(activityPluginBinding, channel); | ||
| cardEntryModule.attachActivityResultListener(activityPluginBinding, channel); | ||
| public void onReattachedToActivityForConfigChanges(ActivityPluginBinding activityBinding) { | ||
| onAttachedToActivity(activityBinding); |
There was a problem hiding this comment.
It's probably light enough not to matter, but there is a reason a config change breaks the two modules here? That is, could we not discard them in all three of detachedFromActivity, detachedFromEngine, and detachedFromActivityForConfigChanges and re-create what I assume is the same thing all those times?
At the least, I bet you never detach from engine except after detaching from activity, so you could instead check(cardEntryModule == null) in onDetachFromEngine, because it should already have been done?
|
|
||
| @Override | ||
| public void onMethodCall(MethodCall call, Result result) { | ||
| switch (call.method) { |
| public void onAttachedToEngine(FlutterPluginBinding flutterPluginBinding) { | ||
| channel = new MethodChannel(flutterPluginBinding.getBinaryMessenger(), "square_in_app_payments"); | ||
|
|
||
| // KNOWN ISSUE: OnAttachedToEngine can be called twice which may be due to https://github.com/flutter/flutter/issues/69721 |
| @@ -1,29 +1,24 @@ | |||
| /* | |||
There was a problem hiding this comment.
We should either have the license header or not, throughout? If it's inconsistent today, don't change that in this PR, though.
| private static final String FL_MESSAGE_GOOGLE_PAY_NOT_INITIALIZED = "Please initialize google pay before you can call other methods."; | ||
| private static final String FL_MESSAGE_GOOGLE_PAY_RESULT_ERROR = "Failed to launch google pay, please make sure you configured google pay correctly."; | ||
| private static final String FL_MESSAGE_GOOGLE_PAY_UNKNOWN_ERROR = "Unknown google pay activity result status."; | ||
| private static final String FL_MESSAGE_GOOGLE_PAY_NOT_INITIALIZED = "Please initialize Google Pay before you can call other methods."; |
There was a problem hiding this comment.
Not for this PR, but shouldn't these be resource strings for translation?
|
i will solve @fka3 comments in another PR |
Summary
This PR updates the Flutter plugin to support Flutter Embedding v2 and newer Flutter versions (specifically Flutter 3.29.3+ with Dart 3.7.2+). The main issue being solved was a compilation error: cannot find symbol class Registrar that occurred when developers upgraded to newer Flutter versions.
Key Changes
Removed deprecated Flutter v1 embedding support (PluginRegistry.Registrar)
Migrated to Flutter v2 embedding using FlutterPlugin and ActivityAware interfaces
Fixed the "cannot find symbol class Registrar" error by removing references to the deprecated PluginRegistry.Registrar
Before:
Used deprecated registerWith() method for v1 embedding
Had static MethodChannel and complex workarounds for double initialization
Mixed v1 and v2 embedding code
After:
Clean v2 embedding implementation with proper lifecycle management
Non-static MethodChannel with proper initialization in onAttachedToEngine()
Simplified method call handling using switch statements instead of if-else chains
Better context management with applicationContext field
Removed workaround comments about double initialization issues
CardEntryModule:
Removed v1 embedding constructor that took PluginRegistry.Registrar
Simplified to single constructor taking Context and MethodChannel
Inline activity result listener instead of separate class
Lambda expressions for cleaner callback handling
Removed copyright header (likely for brevity)
GooglePayModule:
Similar constructor simplification (Context + MethodChannel)
Inline activity result handling with lambda expressions
Cleaner error message strings
Removed deprecated v1 embedding code
Android Build System:
Migrated from Groovy to Kotlin DSL (build.gradle → build.gradle.kts)
Updated to modern Flutter Gradle Plugin (dev.flutter.flutter-gradle-plugin)
Updated Gradle version (8.7 → 8.12)
Simplified build configuration
App Structure:
Updated package structure (sqip.flutter.example → com.sqip.flutter.square_in_app_payments_example)
Modern Android manifest with proper Flutter v2 embedding configuration
Updated themes and styles for modern Android
Added proper debug/profile manifest variants
Removed Legacy Files:
Old custom themes, colors, and drawable resources
Legacy launcher icons and configurations
Deprecated build configurations
Updated .gitignore with modern Flutter patterns
Updated .metadata with Flutter migration tracking
Modernized Gradle properties with better JVM settings
Technical Impact
Compatibility: Now supports Flutter 3.29.3+ and Dart 3.7.2+
Architecture: Cleaner, more maintainable code following Flutter v2 embedding best practices
Performance: Removed workarounds and simplified initialization logic
Future-proofing: Uses current Flutter plugin development patterns
Breaking Changes
Drops support for Flutter v1 embedding (very old Flutter versions)
Requires Flutter 3.0+ (as documented in their requirements)