Proper hreflang for localized entries #400
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 6f2d84b Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:57:44 2025 -0700 not used commit b6ec627 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:57:02 2025 -0700 not used commit c695d7c Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:49:44 2025 -0700 fix more tests commit eaf7b29 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:30:58 2025 -0700 fix more tests commit a767b47 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:28:46 2025 -0700 better commit db53aff Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:13:16 2025 -0700 start testing commit 01a30e6 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:13:10 2025 -0700 ray commit a81f79e Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:44:10 2025 -0700 gotta create commit 8b507ef Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:31:45 2025 -0700 backwards compatible commit 15db562 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:31:38 2025 -0700 tidy commit 30ab43f Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:15:32 2025 -0700 tidy commit 54bf4df Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:14:20 2025 -0700 better way commit 7d7d4e8 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 12:52:05 2025 -0700 wip commit 15ec444 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 11:45:52 2025 -0700 filter out incorrect domains
This reverts commit 5754b09. # Conflicts: # src/Sitemap/Sitemap.php # tests/Localized/SitemapTest.php
commit 6f2d84b Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:57:44 2025 -0700 not used commit b6ec627 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:57:02 2025 -0700 not used commit c695d7c Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:49:44 2025 -0700 fix more tests commit eaf7b29 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:30:58 2025 -0700 fix more tests commit a767b47 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:28:46 2025 -0700 better commit db53aff Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:13:16 2025 -0700 start testing commit 01a30e6 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 14:13:10 2025 -0700 ray commit a81f79e Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:44:10 2025 -0700 gotta create commit 8b507ef Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:31:45 2025 -0700 backwards compatible commit 15db562 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:31:38 2025 -0700 tidy commit 30ab43f Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:15:32 2025 -0700 tidy commit 54bf4df Author: edalzell <erin@silentz.co> Date: Thu Aug 7 13:14:20 2025 -0700 better way commit 7d7d4e8 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 12:52:05 2025 -0700 wip commit 15ec444 Author: edalzell <erin@silentz.co> Date: Thu Aug 7 11:45:52 2025 -0700 filter out incorrect domains
|
Sorry @jesseleite this is ready to go but I'm not sure why the test fails. I'll wait until the other one is merged and give this another look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #399 to be merged first!
When an entry is localized this should in the sitemap: