optimize the fixed32 and fixed64 encoding #772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of write_raw_little_endian32 is just using self.write_raw_bytes.
As this go through the function boundaries, the compiler is not smart enough to simplify the data copy, and end-up calling memcpy.
This inlined implementation is twice as fast as the previous according to the attached bench.
now fixed32/64 is as expected a bit faster than varint