-
Notifications
You must be signed in to change notification settings - Fork 238
STOP-1246 security fix changes #2806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for stoplight-elements failed.
|
✅ Deploy Preview for stoplight-elements-demo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see domspurify package usage in elements core only. Why can't we add the in elements-core package.json?
@prafullaAtSB, Have moved dompurify package from global to elements-core package.json |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes are good to go ahead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing all the review comments. The changes look good to me
Elements Default PR Template
STOP-1246
In general, make sure you have: (check the boxes to acknowledge you've followed this template)
Description
For Lack of Encoding, we have applied the fix, all user-supplied data within the parameterValues is now sanitized before being processed by the application.
How Has This Been Tested?
Tested it locally.
Screenshot(s)/recordings(s)
Input

Before

After

CONTRIBUTING.md
Other Available PR Templates:
CONTRIBUTING.md