Skip to content

STOP-1246 security fix changes #2806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

STOP-1246 security fix changes #2806

wants to merge 10 commits into from

Conversation

SB-venkatyadavilli
Copy link
Contributor

Elements Default PR Template

STOP-1246

In general, make sure you have: (check the boxes to acknowledge you've followed this template)

Description

For Lack of Encoding, we have applied the fix, all user-supplied data within the parameterValues is now sanitized before being processed by the application.

How Has This Been Tested?

Tested it locally.

Screenshot(s)/recordings(s)

Input
image

Before
image

After
image

Other Available PR Templates:

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for stoplight-elements failed.

Name Link
🔨 Latest commit edbfad9
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements/deploys/687f57a8d452820008262402

Copy link

netlify bot commented Jun 26, 2025

Deploy Preview for stoplight-elements-demo ready!

Name Link
🔨 Latest commit edbfad9
🔍 Latest deploy log https://app.netlify.com/projects/stoplight-elements-demo/deploys/687f57a8f257160008d8f67b
😎 Deploy Preview https://deploy-preview-2806--stoplight-elements-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see domspurify package usage in elements core only. Why can't we add the in elements-core package.json?

@SB-venkatyadavilli
Copy link
Contributor Author

I can see domspurify package usage in elements core only. Why can't we add the in elements-core package.json?

@prafullaAtSB, Have moved dompurify package from global to elements-core package.json

Copy link
Contributor

@prafullaAtSB prafullaAtSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good to go ahead.

Copy link

@bhaskarsontakke bhaskarsontakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing all the review comments. The changes look good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants