Add comments for Equal and NotEqual to clarify pointer comparison #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify that pointer equality is determined by equality of values rather than memory address. Fixes stretchr#358
|
@nmiyake back reviewing after a few months of travelling. Changes look good. Thanks! |
jonnyreeves
pushed a commit
to jonnyreeves/testify
that referenced
this pull request
Jan 5, 2017
Add comments for Equal and NotEqual to clarify pointer comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify that pointer equality is determined by equality of values
rather than memory address.
Fixes #358