Skip to content

Share document modal #1045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Share document modal #1045

wants to merge 1 commit into from

Conversation

Comete99
Copy link

@Comete99 Comete99 commented Jun 3, 2025

In the share document modal : aria-hidden=true added for icons + aria-label for the icon 'more actions'

Issue : #966

Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR 🙌

As described in the issue, there are still a couple of small accessibility details to address:

In DocShareModalFooter, the "add_link" icon used in the "Copy link" button is decorative and should be marked with aria-hidden="true" to prevent screen readers from announcing it.

Similarly, in DocVisibility, the lock icon (e.g. "lock", "public") is purely visual and should also include aria-hidden="true".

Aside from that, everything else looks good to me. Thank

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants