breaking: use parseArgs from Node 18.3+ instead of sade/mri #2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace sade dependency with Node.js built-in parseArgs from node:util - Update engines requirement to Node.js >= 18.3.0 (when parseArgs was added) - Remove sade and @types/sade dependencies - Implement custom help and version handling to match original behavior - Add proper TypeScript types for parseArgs options Resolves sveltejs#2521
|
@benmccann @jasonlyu123 let me know if you had something else in mind, happy to address any feedback. |
|
Looks good, but we should only merge this once we cut a new svelte-check release. Putting it into draft mode to prevent accidental merges. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2521