[5.9] Newly created build tool and command plugin templates should have conditional support for XcodeProjectPlugin #6446 #6456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ional support for XcodeProjectPlugin (swiftlang#6446) Many package plugins are used from Xcode, so it makes sense for newly created ones to have that by default. If there is support for other IDEs in the future, it would make sense to add that as well. This support is currently always added but we could consider having options in the API for whether to add it. rdar://108166582 (cherry picked from commit f0eae33)
…ate (swiftlang#6451) This is a supplemental fix for swiftlang#6446 that removes the `async` specifier and corrects the protocol conformance of the Xcode command plug-in. This change should have been part of that PR. - remove the `async` specifier since the entry point that XcodeProjectPlugin defines isn't async - correct the protocol conformance of the Xcode command plug-in - update the unit tests rdar://108166582 (cherry picked from commit 87ecb5d)
|
@swift-ci smoke test |
neonichu
approved these changes
Apr 19, 2023
abertelrud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a SwiftPM 5.9 nomination of #6446 and it's follow-on fix #6451.
Motivation
Package plugins can be applied to packages in Xcode without any modification. But Xcode also has an additional XcodeProjectPlugin module that provides extra API for applying plugins to Xcode projects. Since this is a common use case, it makes sense for newly created plugins to have conditional use of that extra API by default. If there is support for applying plugins to the project formats of other IDEs in the future, it would make sense to add those to the templates as well.
This support is currently always added but we could consider having options in the API for whether to add it.
Modifications
rdar://108166582