Allow swift-corelibs-foundation to use unsafeFlags when used as a d…
#7431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
MaxDesiatov
reviewed
Mar 28, 2024
MaxDesiatov
approved these changes
Mar 28, 2024
…ependency Tagged dependencies don't currently allow use of `unsafeFlags` but we need to temporarily lift that requirement for `swift-corelibs-foundation` that depends on C flags. In the future this would be removed in favor of a more general mechanism for "safe" flags.
xedin
force-pushed
the
unsafe-flags-for-corelibs-foundation
branch
from
96e9244 to
65fb3d3
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ependency
Tagged dependencies don't currently allow use of
unsafeFlagsbut we need to temporarilylift that requirement for
swift-corelibs-foundationthat depends on C flags. In the future thiswould be removed in favor of a more general mechanism for "safe" flags.