[6.0] Remove the addition of external-plugin-path for dev toolchains #7526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SDK macro plugins are now provided within `Platforms/<Platform>.platform/Developer/usr/lib/swift/host/plugins` now, which is always added by the driver. (cherry picked from commit e9791b0)
|
@swift-ci please test |
MaxDesiatov
approved these changes
May 3, 2024
MaxDesiatov
added
bug
swift 6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: SDK macro plugins are now provided within
Platformsand are added by default. There's no need to add an additional path to the toolchain. Doing so prevents the macros in the dev toolchain from being picked up.Scope: Macros
Risk: Low, this path was added prior to macros moving into
Platforms.Testing: Source compat suite passes (which has various macro projects). We could theoretically test we're not adding the argument, but seems a bit weird to do so.
Original PR: #7524
Reviewer: @MaxDesiatov