Skip to content

[6.0.1] Remove @MainActor from XCTest glue. #7960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 17, 2024
Merged

[6.0.1] Remove @MainActor from XCTest glue. #7960

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c111da3
[6.0.0] Remove `@MainActor` from XCTest glue.
grynspan Sep 11, 2024
e1d1364
Make __allTests__ nonisolated
grynspan Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions Sources/Build/LLBuildCommands.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,7 @@ final class TestDiscoveryCommand: CustomLLBuildCommand, TestBuildCommand {

fileprivate extension \#(className) {
@available(*, deprecated, message: "Not actually deprecated. Marked as deprecated to allow inclusion of deprecated tests (which test deprecated functionality) without warnings")
@MainActor
static let __allTests__\#(className) = [
static nonisolated(unsafe) let __allTests__\#(className) = [
\#(testMethods.map(\.allTestsEntry).joined(separator: ",\n "))
]
}
Expand All @@ -88,13 +87,12 @@ final class TestDiscoveryCommand: CustomLLBuildCommand, TestBuildCommand {
content +=
#"""
@available(*, deprecated, message: "Not actually deprecated. Marked as deprecated to allow inclusion of deprecated tests (which test deprecated functionality) without warnings")
@MainActor
func __\#(module)__allTests() -> [XCTestCaseEntry] {
return [
\#(
testsByClassNames.map { "testCase(\($0.key).__allTests__\($0.key))" }
.joined(separator: ",\n ")
)
)
]
}
"""#
Expand Down Expand Up @@ -163,7 +161,6 @@ final class TestDiscoveryCommand: CustomLLBuildCommand, TestBuildCommand {
import XCTest

@available(*, deprecated, message: "Not actually deprecated. Marked as deprecated to allow inclusion of deprecated tests (which test deprecated functionality) without warnings")
@MainActor
public func __allDiscoveredTests() -> [XCTestCaseEntry] {
\#(testsKeyword) tests = [XCTestCaseEntry]()

Expand Down