Synthesize Test instances for all suite types.
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
added
bug
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
I've XFAILed a test for now as we're not 100% sure what to do with it. We'll take a look after the weekend. |
|
@swift-ci please test |
briancroom
reviewed
Mar 22, 2024
| // If the real test is hidden, so shall the synthesized test be hidden. | ||
| // Copy the exact traits from the real test in case they someday carry | ||
| // any interesting metadata. | ||
| let traits = test.traits.compactMap { $0 as? HiddenTrait } |
There was a problem hiding this comment.
Is this no longer needed?
There was a problem hiding this comment.
Yes, it's redundant as we already recursively apply traits like this one during planning.
briancroom
approved these changes
Mar 22, 2024
This PR extends test discovery to synthesize `Test` instances for all suite
types (that is, types containing other suites or test functions but which do not
have the `@Suite` attribute explicitly applied to them.)
This ensures that deep type hierarchies like the following are fully represented
in test plans:
```swift
struct AllTests {
struct FoodTruckTests {
@suite struct MechanicalTests {
struct BatteryTests {
@test func isCharged() { ... }
}
}
}
}
```
Resolves rdar://125241067.
grynspan
force-pushed
the
jgrynspan/125241067-synthesize-more-suites
branch
from
f784cd5 to
fbe535d
Compare
|
@swift-ci please test |
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends test discovery to synthesize
Testinstances for all suite types (that is, types containing other suites or test functions but which do not have the@Suiteattribute explicitly applied to them.)This ensures that deep type hierarchies like the following are fully represented in test plans:
Resolves rdar://125241067.
Checklist: