Fix some variable names in #310. #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grynspan
requested review from
stmontgomery,
dennisweissmann,
briancroom,
SeanROlszewski and
suzannaratcliff
as code owners
|
@swift-ci please test |
This PR fixes some poor variable names I picked in #310. It also optimizes the `==` operator a bit by using the stored FQN instead of computed FQN components.
grynspan
force-pushed
the
jgrynspan/fix-typeinfo-typos
branch
from
0b2c9ff to
80417c0
Compare
|
@swift-ci please test |
briancroom
approved these changes
Mar 23, 2024
dennisweissmann
approved these changes
Mar 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some poor variable names I picked in #310. It also optimizes the
==operator a bit by using the stored FQN instead of computed FQN components. Finally, it fixeshash(into:)producing different hashes depending on the kind case (oops.)Checklist: