Sema: Check custom domain availability during conformance checking #83349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tshortli
requested review from
AnthonyLatsis,
hborla,
slavapestov,
xedin,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar and
susmonteiro
as code owners
For declarations that aren't in source files there isn't an `AvailabilityScope` tree to consult to find their `AvailabilityContext`. The fallback mechanism used by `AvailabilityContext::forLocation()` walks up the `DeclContext` hierarchy to build up the context for implicit code but this isn't entirely correct since it skips over certain kinds of decls (like property declarations). Instead, we need to walk up the parent decl hierarchy that is used for availability inference to ensure that no decls with relevant availability attributes are skipped.
Protocol requirement witnesses cannot only be available in a custom availability domain if the requirement does not have the same availability constraint. Resolves rdar://156462516.
tshortli
force-pushed
the
check-custom-domain-availability-for-conformances
branch
from
76947b0 to
0fabfa3
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protocol requirement witnesses cannot only be available in a custom availability domain if the requirement does not have the same availability constraint.
Resolves rdar://156462516.