Skip to content

fix(posture/zones): correctly handle api errors #637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2025
Merged

fix(posture/zones): correctly handle api errors #637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sysdig/internal/client/v2/posture_controls.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ func (c *Client) GetPostureControl(ctx context.Context, id int64) (*PostureContr
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return nil, c.ErrorFromResponse(response)
}
wrapper, err := Unmarshal[SaveControlResponse](response.Body)
if err != nil {
return nil, err
Expand Down
4 changes: 4 additions & 0 deletions sysdig/internal/client/v2/posture_policies.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,10 @@ func (client *Client) ListPosturePolicies(ctx context.Context) ([]PosturePolicy,
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return nil, client.ErrorFromResponse(response)
}

resp, err := Unmarshal[PostureZonePolicyListResponse](response.Body)
if err != nil {
return nil, err
Expand Down
3 changes: 3 additions & 0 deletions sysdig/internal/client/v2/posture_zones.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,9 @@ func (client *Client) GetPostureZone(ctx context.Context, id int) (*PostureZone,
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return nil, client.ErrorFromResponse(response)
}
wrapper, err := Unmarshal[PostureZoneResponse](response.Body)
if err != nil {
return nil, err
Expand Down
6 changes: 6 additions & 0 deletions sysdig/internal/client/v2/zones.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ func (client *Client) GetZones(ctx context.Context, name string) ([]Zone, error)
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return nil, client.ErrorFromResponse(response)
}
wrapper, err := Unmarshal[ZonesWrapper](response.Body)
if err != nil {
return nil, err
Expand All @@ -46,6 +49,9 @@ func (client *Client) GetZoneById(ctx context.Context, id int) (*Zone, error) {
}
defer response.Body.Close()

if response.StatusCode != http.StatusOK {
return nil, client.ErrorFromResponse(response)
}
zone, err := Unmarshal[Zone](response.Body)
if err != nil {
return nil, err
Expand Down
Loading