Skip to content

Embedding Projector: fix t-SNE control when switching projections #6287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Embedding Projector: fix t-SNE control when switching projections #6287

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions tensorboard/plugins/projector/vz_projector/vz-projector-projections-panel.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,9 +402,10 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
this.customSelectedSearchByMetadataOption =
this.searchByMetadataOptions[Math.max(0, searchByMetadataIndex)];
}
public showTab(id: ProjectionType) {
this.currentProjection = id;
const tab = this.$$('.ink-tab[data-tab="' + id + '"]') as HTMLElement;
public showTab(projection: ProjectionType) {
const tab = this.$$(
'.ink-tab[data-tab="' + projection + '"]'
) as HTMLElement;
const allTabs = this.root?.querySelectorAll('.ink-tab');
if (allTabs) {
for (let i = 0; i < allTabs.length; i++) {
Expand All @@ -419,7 +420,9 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
}
}
util.classed(
this.$$('.ink-panel-content[data-panel="' + id + '"]') as HTMLElement,
this.$$(
'.ink-panel-content[data-panel="' + projection + '"]'
) as HTMLElement,
'active',
true
);
Expand All @@ -432,25 +435,29 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
this.style.height = main.clientHeight + 'px';
});
}
this.beginProjection(id);
this.beginProjection(projection);
}
private beginProjection(projection: ProjectionType) {
if (this.polymerChangesTriggerReprojection === false) {
return;
}
if (projection === 'pca') {
if (this.currentProjection !== projection) {
this.currentProjection = projection;
if (this.dataSet != null) {
this.dataSet.stopTSNE();
if (projection === 'tsne') {
this.dataSet.tSNEShouldPause = false;
} else {
this.dataSet.tSNEShouldPause = true;
}
}
}
if (projection === 'pca') {
this.showPCA();
} else if (projection === 'tsne') {
this.showTSNE();
} else if (projection === 'umap') {
this.showUmap();
} else if (projection === 'custom') {
if (this.dataSet != null) {
this.dataSet.stopTSNE();
}
this.computeAllCentroids();
this.reprojectCustom();
}
Expand Down Expand Up @@ -493,6 +500,7 @@ class ProjectionsPanel extends LegacyElementMixin(PolymerElement) {
(iteration: number) => {
if (iteration != null) {
this.runTsneButton.disabled = false;
this.pauseTsneButton.innerText = 'Pause';
this.pauseTsneButton.disabled = false;
this.iterationLabelTsne.innerText = '' + iteration;
this.projector.notifyProjectionPositionsUpdated();
Expand Down