Don't allow silent failures for Xtensa binaries #3156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tensorflow/micro Do not allow programs, which are not unit tests, to silently fail when run using the Xtensa simulator. The generic benchmark application is one such program for which failures were not being reported. Check the exit status of the simulator when running programs that are not unit tests. bug=fixes tensorflow#3155
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to checks timeout. You can check the last failing draft PR here: #3157. You may have to fix your CI before adding the pull request to the queue again. If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again. |
priyanshscpp
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tensorflow/micro
Do not allow programs, which are not unit tests, to silently fail when run using the Xtensa simulator. The generic benchmark application is one such program for which failures were not being reported.
Check the exit status of the simulator when running programs that are not unit tests.
bug=fixes #3155