Allow SVGElements in matchers #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
|
🎉 This PR is included in version 1.5.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
|
Thanks! Nice catch! And thank you @kentcdodds for filling in for me during my absence. I never thought I'd miss so much action on this repo in these two weeks. It's a nice surprise! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
What: Allows matchers to be used on
SVGElementobjectsWhy: These matchers may be validly used on SVG elements
How: Added
instanceof SVGElementcheck tocheckHtmlElementChecklist: