Skip to content

Added Domain Separator as an input for gasless #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 15, 2024

Conversation

farhanW3
Copy link
Contributor

@farhanW3 farhanW3 commented Feb 21, 2024

Problem solved

getChainDomainSeperator() :: domain :: version, can now be controlled via an exposed variable domainSeparatorVersion.


PR-Codex overview

This PR adds domainSeparatorVersion SDK options for relayers and updates related functions to support it.

Detailed summary

  • Added domainSeparatorVersion SDK option for relayers
  • Updated functions to include domainSeparatorVersion in transactions and permits

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@farhanW3 farhanW3 requested a review from a team February 21, 2024 00:34
Copy link

changeset-bot bot commented Feb 21, 2024

🦋 Changeset detected

Latest commit: bbe6823

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/sdk Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/wallets Patch
@thirdweb-dev/auth Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 66.91%. Comparing base (cc22fa8) to head (bbe6823).

Files Patch % Lines
packages/sdk/src/evm/common/permit.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2332      +/-   ##
==========================================
- Coverage   66.92%   66.91%   -0.02%     
==========================================
  Files         293      293              
  Lines       11250    11252       +2     
  Branches     1564     1566       +2     
==========================================
  Hits         7529     7529              
- Misses       3085     3087       +2     
  Partials      636      636              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquim-verges joaquim-verges added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit d4be647 Mar 15, 2024
@joaquim-verges joaquim-verges deleted the fk/relayer-engine-upds branch March 15, 2024 05:15
@jnsdls jnsdls mentioned this pull request Mar 15, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* contracts landing page v2

* chore: quick fix

* Copy changes

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* case study section fixes

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* Quick hero fix

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: prettier

* chore: requested changes

* Contracts landing page

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* contracts polish

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: prettier

* updated copy on contracts page

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* prettier

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: changes

* gradient fix + copy changes + add CTA at bottom

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: add animation

* gradient

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: links

* chore: small UI change

* chore: remove comments

* chore: quick changes

* chore: carousel

* chore: og-image

* chore: update pnpm lock yaml

* chore: change case study image

* chore: fix

* chore: user select none

* chore: final changes

* case study fixes

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* Explore CTA

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* for creators

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>

* chore: remove react-responsive-carousel

* revert: add Arrows.tsx

---------

Signed-off-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>
Co-authored-by: Juan Leal <114959779+juandolealt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants