[SDK] Expose getAuthToken from inApp and ecosystem wallets #7683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2a2a680 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
## Walkthrough
This update introduces new TypeScript types for in-app and ecosystem wallets, explicitly adding a `getAuthToken` method to their interfaces. Function signatures in related modules are updated to use these refined types. Minor corrections are applied to test cases, and a changeset metadata file is added to document the patch.
## Changes
| File(s) | Change Summary |
|--------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------|
| .changeset/brown-ends-strive.md | Added a changeset file documenting a patch update for exposing `getAuthToken` in wallet types. |
| packages/thirdweb/src/wallets/in-app/core/wallet/types.ts | Introduced `InAppWallet` and `EcosystemWallet` types, both with a `getAuthToken` method. |
| packages/thirdweb/src/wallets/in-app/native/ecosystem.ts | Updated return type and type assertions to use `EcosystemWallet` instead of generic `Wallet`. |
| packages/thirdweb/src/wallets/in-app/native/in-app.ts | Updated return type and type assertions to use `InAppWallet` instead of generic `Wallet`. |
| packages/thirdweb/src/wallets/in-app/web/ecosystem.ts | Updated return type and type assertions to use `EcosystemWallet` instead of generic `Wallet`. |
| packages/thirdweb/src/wallets/in-app/web/in-app.ts | Updated return type and type assertions to use `InAppWallet` instead of generic `Wallet`. |
| packages/thirdweb/src/wallets/in-app/web/lib/in-app-gateway.test.ts | Refined test cases: direct `getAuthToken` calls, corrected response handling, and updated messages. |
## Sequence Diagram(s)
```mermaid
sequenceDiagram
participant App
participant InAppWallet
participant EcosystemWallet
App->>InAppWallet: Call getAuthToken()
InAppWallet-->>App: Return string | null
App->>EcosystemWallet: Call getAuthToken()
EcosystemWallet-->>App: Return string | nullEstimated code review effort2 (~15 minutes) |
joaquim-verges
changed the title
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
joaquim-verges
force-pushed
the
Expose_getAuthToken_from_inApp_and_ecosystem_wallets
branch
from
62d18b5 to
2a2a680
Compare
size-limit report 📦
|
joaquim-verges
deleted the
Expose_getAuthToken_from_inApp_and_ecosystem_wallets
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on enhancing wallet functionality by introducing
getAuthTokenmethods forInAppWalletandEcosystemWallet, updating type definitions, and refining wallet creation functions to return the new types.Detailed summary
getAuthTokenmethod toInAppWalletandEcosystemWallet.inAppWalletandecosystemWalletfunctions toInAppWalletandEcosystemWallet, respectively.Summary by CodeRabbit
New Features
Bug Fixes
Chores