-
Notifications
You must be signed in to change notification settings - Fork 564
[SDK] Improve WalletConnect connection and auto-connection flow #7746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Improve WalletConnect connection and auto-connection flow #7746
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: a3384ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis update refactors the WalletConnect connection and auto-connection flows within the "thirdweb" package. The changes simplify platform-specific logic, unify mobile deep-link handling, improve error logging, and adjust the session management for WalletConnect providers. No public API signatures are altered. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant WalletConnectProvider
participant Wallet App
participant QRModal
User->>App: Initiates WalletConnect connection
App->>WalletConnectProvider: Request connection
alt Mobile device
App->>Wallet App: Open deep link (native/universal) with WC URI
else Desktop
App->>QRModal: Display QR code overlay with WC URI
User->>Wallet App: Scan QR code
end
Wallet App->>WalletConnectProvider: Establish session
WalletConnectProvider->>App: Connection established
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~15–25 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (3)
🧰 Additional context used📓 Path-based instructions (3)**/*.{ts,tsx}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
**/*.{ts,tsx,js,jsx}📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
packages/thirdweb/src/wallets/**📄 CodeRabbit Inference Engine (CLAUDE.md)
Files:
🧠 Learnings (3)📓 Common learnings
packages/thirdweb/src/utils/web/isMobile.ts (6)Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR packages/thirdweb/src/wallets/wallet-connect/controller.ts (7)Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: CR Learnt from: joaquim-verges Learnt from: jnsdls ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (6)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
33b713c
to
a3384ca
Compare
size-limit report 📦
|
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (6.02%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7746 +/- ##
=======================================
Coverage 56.22% 56.22%
=======================================
Files 905 905
Lines 58880 58864 -16
Branches 4134 4131 -3
=======================================
- Hits 33106 33098 -8
+ Misses 25669 25663 -6
+ Partials 105 103 -2
🚀 New features to boost your workflow:
|
PR-Codex overview
This PR focuses on improving the
walletConnect
connection and auto-connection flow, enhancing mobile support, and cleaning up the code for better readability and maintainability.Detailed summary
isAndroid
andisIOS
functions to remove export.autoConnectWC
to handle session disconnection.onDisplayUri
to support mobile app links.WalletConnectStandaloneConnection
.Summary by CodeRabbit
New Features
Bug Fixes
Chores