Skip to content

Conversation

FarzadHayat
Copy link
Contributor

  • The page(s) are in the correct platform directories: common, linux, osx, windows, sunos, android, etc.
  • The page(s) have at most 8 examples.
  • The page description(s) have links to documentation or a homepage.
  • The page(s) follow the content guidelines.
  • The PR title conforms to the recommended templates.
  • Version of the command being documented (if known): 2.38.1

For delpart command as part of util-linux in #2214
Sudo is necessary to get correct permission level.

I think adding a concrete example like:
sudo delpart /dev/sda 1
would help provide more clarity on how to use the command.
I'm not sure whether this would fit into the tldr page structure though.

@github-actions github-actions bot added the new command Issues requesting creation of a new page or PRs adding a new page for a command. label Oct 21, 2023
Copy link
Member

@kbdharun kbdharun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to tldr and thanks for your contribution.

LGTM, after @acuteenvy's suggestions.

sebastiaanspeck and others added 2 commits October 21, 2023 21:45
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
Co-authored-by: Lena <126529524+acuteenvy@users.noreply.github.com>
@sebastiaanspeck sebastiaanspeck merged commit 44e52ce into tldr-pages:main Oct 21, 2023
@FarzadHayat FarzadHayat deleted the add-delpart branch October 21, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page or PRs adding a new page for a command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants