refactor: return enum for MutableMemTable #408
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanc-n
approved these changes
Jul 27, 2025
There was a problem hiding this comment.
This shouldn't need additional tests. It does make the code look a little messier but it makes it much clearer what is being returned. Thanks for the contribution @ronaudinho! Just a small comment below
jonathanc-n
reviewed
Jul 27, 2025
ronaudinho
force-pushed
the
memtable-enum
branch
from
46c2fd4 to
e322c80
Compare
ronaudinho
force-pushed
the
memtable-enum
branch
from
e322c80 to
033ffc4
Compare
ronaudinho
commented
Jul 28, 2025
| } | ||
|
|
||
| impl WriteResult { | ||
| pub fn needs_compaction(&self) -> bool { |
There was a problem hiding this comment.
adding this mainly to make python binding build success, but end up using this in other parts too.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Thank you @ronaudinho ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #392
I ran existing tests but nothing is broken by these changes, any pointer as to where to add appropriate tests is appreciated.
P.S. re-reading the diffs, I feel like the current bool version is clearer, especially at call sites