-
Notifications
You must be signed in to change notification settings - Fork 16
fix(PM-1448): implemented client side infinite scroll #1131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9f88d4a
fix: implemented client side infinite scroll
hentrymartin 3c10762
fix: implemented client side infinite scroll
hentrymartin e621c94
fix: modified the scroll event
hentrymartin d565783
fix: modified the scroll event
hentrymartin 75aa8cb
fix: lint
hentrymartin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
import { FC, useCallback, useState } from 'react' | ||
import { FC, useCallback, useEffect, useState } from 'react' | ||
import classNames from 'classnames' | ||
|
||
import { Button, ContentLayout, LinkButton, LoadingCircles } from '~/libs/ui' | ||
|
@@ -17,6 +17,9 @@ import styles from './SearchResultsPage.module.scss' | |
const SearchResultsPage: FC = () => { | ||
const [showSkillsModal, setShowSkillsModal] = useState(false) | ||
|
||
const [currentPage, setCurrentPage] = useState(1) | ||
const itemsPerPage = 10 | ||
|
||
const [skills, setSkills] = useUrlQuerySearchParms('q') | ||
const { | ||
loading, | ||
|
@@ -25,6 +28,27 @@ const SearchResultsPage: FC = () => { | |
hasNext, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo in |
||
total, | ||
}: InfiniteTalentMatchesResposne = useInfiniteTalentMatches(skills) | ||
const paginatedMatches = matches.slice(0, currentPage * itemsPerPage) | ||
|
||
useEffect(() => { | ||
const handleScroll: () => void = () => { | ||
const scrollY = window.scrollY | ||
const visibleHeight = window.innerHeight | ||
const fullHeight = document.body.scrollHeight | ||
const footerElem = document.getElementById('footer-nav-el') | ||
const footerHeight = (footerElem && footerElem.offsetHeight) || 650 | ||
if (scrollY + visibleHeight >= fullHeight - (footerHeight + 100)) { | ||
hentrymartin marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// Scroll near bottom | ||
setCurrentPage(prev => { | ||
const maxPages = Math.ceil(matches.length / itemsPerPage) | ||
return prev < maxPages ? prev + 1 : prev | ||
}) | ||
} | ||
} | ||
|
||
window.addEventListener('scroll', handleScroll) | ||
return () => window.removeEventListener('scroll', handleScroll) | ||
}, [matches]) | ||
|
||
const toggleSkillsModal = useCallback(() => setShowSkillsModal(s => !s), []) | ||
|
||
|
@@ -100,7 +124,7 @@ const SearchResultsPage: FC = () => { | |
)} | ||
</div> | ||
<div className={styles.resultsWrap}> | ||
{matches.map(member => ( | ||
{paginatedMatches.map(member => ( | ||
<TalentCard | ||
queriedSkills={skills} | ||
member={member} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider making
itemsPerPage
a constant outside of the component if it does not change, to avoid re-declaring it on every render.