Skip to content

fix(PM-1448): implemented client side infinite scroll #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { FC, useCallback, useState } from 'react'
import { FC, useCallback, useEffect, useState } from 'react'
import classNames from 'classnames'

import { Button, ContentLayout, LinkButton, LoadingCircles } from '~/libs/ui'
Expand All @@ -17,6 +17,9 @@ import styles from './SearchResultsPage.module.scss'
const SearchResultsPage: FC = () => {
const [showSkillsModal, setShowSkillsModal] = useState(false)

const [currentPage, setCurrentPage] = useState(1)
const itemsPerPage = 10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider making itemsPerPage a constant outside of the component if it does not change, to avoid re-declaring it on every render.


const [skills, setSkills] = useUrlQuerySearchParms('q')
const {
loading,
Expand All @@ -25,6 +28,27 @@ const SearchResultsPage: FC = () => {
hasNext,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in InfiniteTalentMatchesResposne, it should be InfiniteTalentMatchesResponse.

total,
}: InfiniteTalentMatchesResposne = useInfiniteTalentMatches(skills)
const paginatedMatches = matches.slice(0, currentPage * itemsPerPage)

useEffect(() => {
const handleScroll: () => void = () => {
const scrollY = window.scrollY
const visibleHeight = window.innerHeight
const fullHeight = document.body.scrollHeight
const footerElem = document.getElementById('footer-nav-el')
const footerHeight = (footerElem && footerElem.offsetHeight) || 650
if (scrollY + visibleHeight >= fullHeight - (footerHeight + 100)) {
// Scroll near bottom
setCurrentPage(prev => {
const maxPages = Math.ceil(matches.length / itemsPerPage)
return prev < maxPages ? prev + 1 : prev
})
}
}

window.addEventListener('scroll', handleScroll)
return () => window.removeEventListener('scroll', handleScroll)
}, [matches])

const toggleSkillsModal = useCallback(() => setShowSkillsModal(s => !s), [])

Expand Down Expand Up @@ -100,7 +124,7 @@ const SearchResultsPage: FC = () => {
)}
</div>
<div className={styles.resultsWrap}>
{matches.map(member => (
{paginatedMatches.map(member => (
<TalentCard
queriedSkills={skills}
member={member}
Expand Down